Compartmentalize AtespaceExists() - #1149
Merged
Luiz Oliveira (laoj2) merged 1 commit intoAug 24, 2026
Merged
Conversation
Tim Hockin (thockin)
changed the title
Luiz Oliveira (laoj2)
previously approved these changes
Aug 24, 2026
This needs to be a property of the storage layer. It is in PG but not in redis. This commit moves it out of the store interface and down into redis. It's still not CORRECT but it constrains it. This requires a lot of tests to create the atespace before creating other resources. These tests are wrong in the face of a correct storage layer, anyway.
Tim Hockin (thockin)
force-pushed
the
kill_atespace_exists
branch
from
August 24, 2026 19:00
025063e to
490c9cb
Compare
Collaborator
Author
|
Rebased |
Luiz Oliveira (laoj2)
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This needs to be a property of the storage layer. It is in PG but not in redis. This commit moves it out of the store interface and down into redis. It's still not CORRECT but it constrains it.
This requires a lot of tests to create the atespace before creating other resources. These tests are wrong in the face of a correct storage layer, anyway.
xref #989